Clarify description of "checking" iceConnectionState #2884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
which can happen without explicitly adding remote candidates via addIceCandidate when candidate pairs are formed after discovering a peer-reflexive candidate upon receiving a valid STUN binding request Fixes w3c#2878
fippo
commented
Jun 27, 2023
Co-authored-by: Dominique Hazael-Massieux <[email protected]>
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 27, 2023
test for w3c/webrtc-pc#2884 BUG=None Change-Id: I3cacefbb158342a53443f73dbb72784b7dceb21b
youennf
approved these changes
Jun 29, 2023
aboba
approved these changes
Jun 29, 2023
jan-ivar
approved these changes
Jun 29, 2023
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 29, 2023
test for w3c/webrtc-pc#2884 BUG=webrtc:9086 Change-Id: I3cacefbb158342a53443f73dbb72784b7dceb21b
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Jun 29, 2023
test for w3c/webrtc-pc#2884 BUG=webrtc:9086 Change-Id: I3cacefbb158342a53443f73dbb72784b7dceb21b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4649349 Commit-Queue: Philipp Hancke <[email protected]> Reviewed-by: Harald Alvestrand <[email protected]> Cr-Commit-Position: refs/heads/main@{#1164320}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 29, 2023
test for w3c/webrtc-pc#2884 BUG=webrtc:9086 Change-Id: I3cacefbb158342a53443f73dbb72784b7dceb21b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4649349 Commit-Queue: Philipp Hancke <[email protected]> Reviewed-by: Harald Alvestrand <[email protected]> Cr-Commit-Position: refs/heads/main@{#1164320}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 29, 2023
test for w3c/webrtc-pc#2884 BUG=webrtc:9086 Change-Id: I3cacefbb158342a53443f73dbb72784b7dceb21b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4649349 Commit-Queue: Philipp Hancke <[email protected]> Reviewed-by: Harald Alvestrand <[email protected]> Cr-Commit-Position: refs/heads/main@{#1164320}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jul 12, 2023
…IceCandidate from the remote end, a=testonly Automatic update from web-platform-tests webrtc wpt: allow 'checking' without addIceCandidate from the remote end test for w3c/webrtc-pc#2884 BUG=webrtc:9086 Change-Id: I3cacefbb158342a53443f73dbb72784b7dceb21b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4649349 Commit-Queue: Philipp Hancke <[email protected]> Reviewed-by: Harald Alvestrand <[email protected]> Cr-Commit-Position: refs/heads/main@{#1164320} -- wpt-commits: 7397a1fd89852237f5ded49469823f2284952a5b wpt-pr: 40765
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Jul 16, 2023
…IceCandidate from the remote end, a=testonly Automatic update from web-platform-tests webrtc wpt: allow 'checking' without addIceCandidate from the remote end test for w3c/webrtc-pc#2884 BUG=webrtc:9086 Change-Id: I3cacefbb158342a53443f73dbb72784b7dceb21b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4649349 Commit-Queue: Philipp Hancke <phanckemicrosoft.com> Reviewed-by: Harald Alvestrand <htachromium.org> Cr-Commit-Position: refs/heads/main{#1164320} -- wpt-commits: 7397a1fd89852237f5ded49469823f2284952a5b wpt-pr: 40765 UltraBlame original commit: d0a48f821bc9c29b0313b188755f8001f3c2258d
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Jul 16, 2023
…IceCandidate from the remote end, a=testonly Automatic update from web-platform-tests webrtc wpt: allow 'checking' without addIceCandidate from the remote end test for w3c/webrtc-pc#2884 BUG=webrtc:9086 Change-Id: I3cacefbb158342a53443f73dbb72784b7dceb21b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4649349 Commit-Queue: Philipp Hancke <phanckemicrosoft.com> Reviewed-by: Harald Alvestrand <htachromium.org> Cr-Commit-Position: refs/heads/main{#1164320} -- wpt-commits: 7397a1fd89852237f5ded49469823f2284952a5b wpt-pr: 40765 UltraBlame original commit: d0a48f821bc9c29b0313b188755f8001f3c2258d
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Jul 16, 2023
…IceCandidate from the remote end, a=testonly Automatic update from web-platform-tests webrtc wpt: allow 'checking' without addIceCandidate from the remote end test for w3c/webrtc-pc#2884 BUG=webrtc:9086 Change-Id: I3cacefbb158342a53443f73dbb72784b7dceb21b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4649349 Commit-Queue: Philipp Hancke <phanckemicrosoft.com> Reviewed-by: Harald Alvestrand <htachromium.org> Cr-Commit-Position: refs/heads/main{#1164320} -- wpt-commits: 7397a1fd89852237f5ded49469823f2284952a5b wpt-pr: 40765 UltraBlame original commit: d0a48f821bc9c29b0313b188755f8001f3c2258d
ErichDonGubler
pushed a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Jul 16, 2023
…IceCandidate from the remote end, a=testonly Automatic update from web-platform-tests webrtc wpt: allow 'checking' without addIceCandidate from the remote end test for w3c/webrtc-pc#2884 BUG=webrtc:9086 Change-Id: I3cacefbb158342a53443f73dbb72784b7dceb21b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4649349 Commit-Queue: Philipp Hancke <[email protected]> Reviewed-by: Harald Alvestrand <[email protected]> Cr-Commit-Position: refs/heads/main@{#1164320} -- wpt-commits: 7397a1fd89852237f5ded49469823f2284952a5b wpt-pr: 40765
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which can happen without explicitly adding remote candidates via addIceCandidate when candidate pairs are formed after discovering a peer-reflexive candidate upon receiving a valid STUN binding request
Fixes #2878
(editorial I would say, no normative change; will add a WPT)
Preview | Diff